Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRVKP-4014: Pull tasks from the tekton ecosystem catalog #2127

Merged
merged 1 commit into from
May 14, 2024
Merged

SRVKP-4014: Pull tasks from the tekton ecosystem catalog #2127

merged 1 commit into from
May 14, 2024

Conversation

Aneesh-M-Bhat
Copy link
Contributor

@Aneesh-M-Bhat Aneesh-M-Bhat commented Apr 25, 2024 •
edited
Loading

Changes

  • Added resolverTasks to tektonconfig to support ecosystem tasks
  • Required Behaviour -> when resolverTasks is true in tekton config, it should populate openshift-pipelines namespace with ecosystem tasks & on making the param value as false, it should remove them.
  • JIRA: https://issues.redhat.com/browse/SRVKP-4014

Release Notes

Added new Addon field "namespacedTasks" to support populating openshift-pipelines namespace with tasks similar to the current clusterTasks.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024
@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2024
@tekton-robot
Copy link
Contributor

Hi @Aneesh-M-Bhat. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2024
khrm
khrm reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/namespacedTask.go Do not exist 0.0%

@Aneesh-M-Bhat Aneesh-M-Bhat changed the title [WIP] SRVKP-4014: Pull tasks from the tekton ecosystem catalog SRVKP-4014: Pull tasks from the tekton ecosystem catalog Apr 29, 2024
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/namespacedTask.go Do not exist 0.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/namespacedTask.go Do not exist 0.0%

jkandasa
jkandasa approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aneesh-M-Bhat Please update the release notes

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@savitaashture
Copy link
Contributor

LGTM 👍

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 8, 2024
@jkandasa
Copy link
Member

jkandasa commented May 8, 2024 •
edited
Loading

LGTM
cc @piyush-garg

@piyush-garg
Copy link
Contributor

Only thing i feel is missing, to add role for all users to get and list task in openshift-pipelines namespace

@piyush-garg
Copy link
Contributor

also the images that we want to replace, should we add in config.yaml file?

@piyush-garg
Copy link
Contributor

Also the param field namespacesTasks does not give much sense, we can keep it simple tasks or resolvertasks or ecosystemtasks

@savitaashture
Copy link
Contributor

also the images that we want to replace, should we add in config.yaml file?

Now ecosystem tasks don't expose any param to replace images

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/resolverTask.go Do not exist 0.0%

@piyush-garg
Copy link
Contributor

also the images that we want to replace, should we add in config.yaml file?

Now ecosystem tasks don't expose any param to replace images

It is only about what is exposed, we may want to replace them in steps also. But if that is the case, we dont need prefix and tanformer then

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/resolverTask.go Do not exist 0.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/resolverTask.go Do not exist 0.0%

@piyush-garg
Copy link
Contributor

/approve

cc @jkandasa have a look once more on final version

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/resolverTask.go Do not exist 0.0%

jkandasa
jkandasa approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa, piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jkandasa,piyush-garg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

savitaashture
savitaashture reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aneesh-M-Bhat can you also update the release note to include resolverTasks

Added new Addon field "resolverTasks" to support populating tasks in openshift-pipelines namespace with tasks similar to the current clusterTasks.

hack/openshift/fetch-tektoncd-catalog-tasks.sh
['task-s2i-ruby']='0.3.1'
['task-skopeo-copy']='0.3.1'
['task-tkn']='0.1.0'
['task-buildpacks']='0.1.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should ship task-buildpacks because today we don't have such tasks in ClusteTasks cc @vdemeester

@piyush-garg
Copy link
Contributor

/test pull-tekton-operator-integration-tests

@tekton-robot tekton-robot merged commit 202addb into tektoncd:main May 14, 2024
8 checks passed
@jkandasa jkandasa added the kind/feature Categorizes issue or PR as related to a new feature. label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg left review comments

@savitaashture savitaashture savitaashture left review comments

@jkandasa jkandasa jkandasa approved these changes

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

@khrm khrm Awaiting requested review from khrm

Assignees

@jkandasa jkandasa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Aneesh-M-Bhat @tekton-robot @savitaashture @jkandasa @piyush-garg @khrm